Skip to content

Remove incorrect ConstraintPrimal method in favor of fallback #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

Remove incorrect ConstraintPrimal method in favor of fallback #85

merged 1 commit into from
Nov 8, 2023

Conversation

@odow
Copy link
Member

@odow odow commented Oct 25, 2022

This is technically breaking, but it's currently incorrect, and most users should be using the cache (in which case, it isn't breaking).

Thoughts @blegat?

@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Base: 56.59% // Head: 56.59% // No change to project coverage 👍

Coverage data is based on head (ad6e8f4) compared to base (ad6e8f4).
Patch has no changes to coverable lines.

❗ Current head ad6e8f4 differs from pull request most recent head 165c896. Consider uploading reports for the commit 165c896 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   56.59%   56.59%           
=======================================
  Files           9        9           
  Lines         827      827           
=======================================
  Hits          468      468           
  Misses        359      359

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

blegat
blegat approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's non-breaking, it can go in a minor 1.x release. This was a workaround for tests to pass which is not needed anymore. It should not give any change for users using MOI.instantiate(CSDP.Optimizer) which is the recommended way of using a solver with MOI directly.

@odow odow closed this Nov 8, 2023
@odow odow reopened this Nov 8, 2023
@odow odow merged commit be142a5 into master Nov 8, 2023
@odow odow deleted the od/primal branch November 8, 2023 18:35
This was referenced Dec 14, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blegat blegat blegat approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odow @blegat